New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle more complex mf2 combinations #701
Comments
Thanks Ben. Tagging @Phyks too; he was helping me test this issue earlier. |
yep, same thing here. While trying to debug it yesterday, I found some unassigned PHP variables, #699. After the fix for issue #699, I got an email notification when firing the webmention, but nothing shows in Known (no comment). Did not have time yesteday to debug it further, but you seem to have clues :) |
The notification should be triggered at the point at which it's saved, so this suggests a template issue. I'm checking it out. |
Mentions should now correctly display as of the latest commit (although new mentions will display a little better). |
I should clarify that this doesn't yet address properly determining mention type when the contents of the reply URL class is a complex structure. |
@benwerd I updated to the latest commit. Same thing, notification triggered but nothing displayed in the template: https://known.phyks.me/2015/publishing-through-the-known-api. |
accept "u-in-reply-to h-cite" in addition to "u-in-reply-to" by checking each property value to see if it is a complex value, and extracting the "url" property if it is. should fix idno#701
accept "u-in-reply-to h-cite" in addition to "u-in-reply-to" by checking each property value to see if it is a complex value, and extracting the "url" property if it is. should fix idno#701
accept "u-in-reply-to h-cite" in addition to "u-in-reply-to" by checking each property value to see if it is a complex value, and extracting the "url" property if it is. should fix idno#701
@kylewm used this post:
https://kylewm.com/2015/01/we-are-admiring-your-podcast-in-indiechat-i-hope
To link to this post:
http://werd.io/2014/shoplifters-and-thieves-podcastsunday
But Known didn't handle it because the microformats boiled down to a p-in-reply-to with a bunch of objects inside it. It's worth going back and making sure we support the full set of expected indieweb variables.
The text was updated successfully, but these errors were encountered: