Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more complex mf2 combinations #701

Closed
benwerd opened this issue Jan 10, 2015 · 6 comments · Fixed by #720
Closed

Handle more complex mf2 combinations #701

benwerd opened this issue Jan 10, 2015 · 6 comments · Fixed by #720

Comments

@benwerd
Copy link
Member

benwerd commented Jan 10, 2015

@kylewm used this post:

https://kylewm.com/2015/01/we-are-admiring-your-podcast-in-indiechat-i-hope

To link to this post:

http://werd.io/2014/shoplifters-and-thieves-podcastsunday

But Known didn't handle it because the microformats boiled down to a p-in-reply-to with a bunch of objects inside it. It's worth going back and making sure we support the full set of expected indieweb variables.

@kylewm
Copy link
Collaborator

kylewm commented Jan 10, 2015

Thanks Ben. Tagging @Phyks too; he was helping me test this issue earlier.

@Phyks
Copy link
Contributor

Phyks commented Jan 10, 2015

yep, same thing here. While trying to debug it yesterday, I found some unassigned PHP variables, #699. After the fix for issue #699, I got an email notification when firing the webmention, but nothing shows in Known (no comment). Did not have time yesteday to debug it further, but you seem to have clues :)

@benwerd
Copy link
Member Author

benwerd commented Jan 10, 2015

The notification should be triggered at the point at which it's saved, so this suggests a template issue. I'm checking it out.

@benwerd
Copy link
Member Author

benwerd commented Jan 10, 2015

Mentions should now correctly display as of the latest commit (although new mentions will display a little better).

@benwerd
Copy link
Member Author

benwerd commented Jan 10, 2015

I should clarify that this doesn't yet address properly determining mention type when the contents of the reply URL class is a complex structure.

@Phyks
Copy link
Contributor

Phyks commented Jan 10, 2015

@benwerd I updated to the latest commit. Same thing, notification triggered but nothing displayed in the template: https://known.phyks.me/2015/publishing-through-the-known-api.

kylewm added a commit to kylewm/Known that referenced this issue Jan 18, 2015
accept "u-in-reply-to h-cite" in addition to "u-in-reply-to" by
checking each property value to see if it is a complex value, and
extracting the "url" property if it is.

should fix idno#701
kylewm added a commit to kylewm/Known that referenced this issue Jan 18, 2015
accept "u-in-reply-to h-cite" in addition to "u-in-reply-to" by
checking each property value to see if it is a complex value, and
extracting the "url" property if it is.

should fix idno#701
kylewm added a commit to kylewm/Known that referenced this issue Jan 18, 2015
accept "u-in-reply-to h-cite" in addition to "u-in-reply-to" by
checking each property value to see if it is a complex value, and
extracting the "url" property if it is.

should fix idno#701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants