Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't set CATAI_OPEN_IN_BROWSER to false #13

Closed
rakete opened this issue May 13, 2023 · 2 comments
Closed

Can't set CATAI_OPEN_IN_BROWSER to false #13

rakete opened this issue May 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@rakete
Copy link

rakete commented May 13, 2023 •
edited

The || true in this line:

https://github.com/ido-pluto/catai/blob/c53b1b2dc6af8bcbbaf53c9a0d4e45f1187b2caf/server/src/config.js#L4

prevents setting CATAI_OPEN_IN_BROWSER to anything other then true. When it's set to false it will default to || true.
@ido-pluto
Copy link
Collaborator

Thanks for reporting!
Yes, this avoids the purpose of default.
In the meantime change the || to ??.

It will be fixed in the next version :)

@ido-pluto
Copy link
Collaborator

Checkout version 0.3.8

@ido-pluto ido-pluto added the bug Something isn't working label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rakete @ido-pluto