Support Circle CI #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class CircleCI < Base | ||
| name 'Circle CI' | ||
| identifier :circle_ci | ||
| icon_url 'https://circleci.com/favicon.ico' |
There was a problem hiding this comment.
Would you like to use Gravatar? It looks beautiful on retina display.
icon_url gravatar('c37e5f37d63fe731f139b7da3f759139')There was a problem hiding this comment.
👌 , thanks for review! i changed it and force pushed ⭐
[original circle_ci.json is here](https://circleci.com/docs/api#build), I modified a little to get closer to a real request.
|
Great! Looks good to me. We will apply this feature as soon as possible. |
|
We released this great feature. |
|
@tricknotes @ursm 🆒 💚 many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original circle_ci.json is here,
I modified a little to get closer to a real request.
preview hook:
