Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standalone distro per @SheetJSDev suggestion #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabrieljoelc
Copy link
Contributor

This is per @SheetJSDev suggestion:

The distribution has standalone single-file versions such as https://github.com/SheetJS/js-xlsx/blob/master/dist/xlsx.core.min.js

I guess you need to be good with the jszip requirement not being obvious and that this uses a minified file.

@SheetJSDev
Copy link

@gabrieljoelc FWIW i plan on replacing the jszip library with something more robust (combined with https://github.com/SheetJS/js-cfb to support password-protected files), so it's probably better this way. I can add the non-minified file if that's preferable

@gabrieljoelc
Copy link
Contributor Author

Sounds good. Minified doesn't bother me. I'll let @such decide. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants