Fix: Error is raised when retrying failed tasks for OPENSPP #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rommel Terrence Juanillo <terrence@newlogic.com>
renceInbox
force-pushed
the
fix/205888-error-when-retrying-task
branch
from
f183055
to
8b0dd82
Compare
kneckinator
requested changes
May 24, 2023
card_generator/tasks/cards.py
Outdated
| @@ -12,6 +13,38 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| class OPENSPPCeleryTask(Task): | |||
| max_retries = 3 | |||
There was a problem hiding this comment.
@renceInbox this variable seems to be unused. If it is not unused, this setting should be provided through an environment variable.
card_generator/tasks/cards.py
Outdated
| @@ -109,14 +142,14 @@ def merge_cards(self, batch_id: int) -> None: | |||
| ) | |||
| except Exception as e: # noqa Lets catch all errors error for debugging and retry | |||
| logger.info(f"Error raised on client. {str(e)}") | |||
| self.retry(exc=e, countdown=30) | |||
| return | |||
| raise self.retry(exc=e, countdown=30) | |||
There was a problem hiding this comment.
@renceInbox please make the retry interval (countdown) a setting provided through an environment variable.
card_generator/tasks/cards.py
Outdated
| client.update_queue_batch_record(batch_id=batch_id, data=data) | ||
| self.retry(exc=e, countdown=30) | ||
| return | ||
| raise self.retry(countdown=30) |
There was a problem hiding this comment.
@renceInbox same comment as above – the should be an env setting.
kneckinator
approved these changes
May 24, 2023
kneckinator
merged commit 46da0e4
into
fix/specify-ssl-context-for-xmlrpc
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.retry(exc=e, countdown=30)restart: Alwayson prod config for celeryerror_mergingwhen the task failed instead on the first retry.