Reviewtestcases #20
Merged
Reviewtestcases #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2021 20:54
jeremi
requested changes
Jan 4, 2021
jeremi
requested changes
Jan 4, 2021
added 11 commits
January 4, 2021 22:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current test cases in
TestCases.javais difficult to follow because it has become an accumulation of old test cases and new test cases across the changes. Keep these old existing test case, but slowly migrate small chunks of test cases and narrate describe a test case flow.Changes
NarrativeTestCases.javaand gradually migrate small chunks of test cases to this fileCard::asQRCodemethod for scaling, and margin option to prevent Zxing intermittent test case failure when scanning image file due to Zxing default algorithm