Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should require re-enabling of biometric identification when biometrics have been added on device #167

Open
celinenilla opened this issue Apr 27, 2022 · 6 comments · Fixed by #215
Assignees
Labels
bug Something isn't working

Comments

@celinenilla
Copy link
Collaborator

Describe the bug
When using biometrics to access the app, the app will not detect if changes have been made to the added biometrics on the device. For comparison, on other apps using the biometrics of the device, it will require entering the passcode to re-enable the biometric identification.

To Reproduce
Steps to reproduce the behavior:

  1. Add biometrics to device
  2. Activate biometrics logon for the resident app
  3. Log out of the app
  4. Add a second fingerprint to the device
  5. Log on to the app
  6. Note that it allows you to log on without additional identification

Expected behavior
App should require passcode in order to re-enable biometric identification

Identified on
0.3.0 RC1
Galaxy A20S, Android 11

@celinenilla celinenilla added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet labels Apr 27, 2022
@pmigueld
Copy link
Collaborator

Found a library we can use for this:
https://github.com/MaxToyberman/react-native-fingerprint-change

@kneckinator
Copy link
Collaborator

The library looks old ok albeit a little bit outdated. However, the code in the library amounts to almost nothing so should not be hard to maintain if we need to. However, it is lacking a LICENSE file. @pmigueld Could you try to ping the package owner and see if he could add a license file to the repo? I see that he is using MIT for his other public repos.

@kneckinator kneckinator removed the triage This issue is pending confirmation and planning and should not be worked on yet label Jul 14, 2022
@kneckinator kneckinator assigned kyanthony and unassigned jeremi and kneckinator Jul 14, 2022
@danicaerediano
Copy link
Collaborator

@ken @pmigueld @kyanthony this library https://github.com/MaxToyberman/react-native-fingerprint-change has problems with dependencies, so I'll be using this instead https://openbase.com/js/react-native-biometrics-changed
the problem is it does not support IOS

@jannahadlaon
Copy link

Tested this ticket on the build versions below, and was not able to meet the expected behavior. This ticket has been assigned back to dev @pmigueld

iOS: Build version 0.4.0 (6)
Android: 0.4.0 RC1

Steps to reproduce the behavior:

  1. Add biometrics to device
  2. Activate biometrics logon for the resident app
  3. Log out of the app
  4. Add a second fingerprint to the device
  5. Log on to the app
  6. Note that it allows you to log on without additional identification

Expected behavior
App should require passcode in order to re-enable biometric identification

Devices
iPhone SE (iOS 15.4)
iPhone 11 (iOS 15.5)
Samsung Galaxy A20s (Android 11)
Samsung Galaxy A23 (Android 12)

@jannahadlaon
Copy link

jannahadlaon commented Sep 21, 2022

Tested on iOS build v0.4.0 (6.3) and Android build v0.4.0-rc1-5-e253490

Devices:
Samsung Galaxy A23
iPhone SE

Android build WORKS AS EXPECTED
iOS build FAILED (refer to: #167 (comment))

@kyanthony
Copy link
Collaborator

Limitation on iOS, no solution as of now. This ticket can be closed and iOS issue will be documented in the Android/iOS document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
7 participants