Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linkedin group to navigation #297

Closed
Idrinth opened this issue Feb 10, 2024 · 12 comments · Fixed by #335
Closed

add linkedin group to navigation #297

Idrinth opened this issue Feb 10, 2024 · 12 comments · Fixed by #335
Assignees
Labels
component: documentation-website related to the project's website, not the framework documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@Idrinth
Copy link
Member

Idrinth commented Feb 10, 2024

Context

We have a linkedIn group for support and experience exchange. It should be linked on the website as well, maybe moving into a new sub-menu with the other external header links.

Link: https://www.linkedin.com/groups/9588634/

@Idrinth Idrinth added documentation Improvements or additions to documentation good first issue Good for newcomers component: documentation-website related to the project's website, not the framework labels Feb 10, 2024
@Idrinth Idrinth added this to the 2.7.0 milestone Feb 10, 2024
@AdityaBhate
Copy link
Contributor

AdityaBhate commented Feb 17, 2024

can I work on this?
I would like to contribute...

@Idrinth
Copy link
Member Author

Idrinth commented Feb 17, 2024

sure, go right ahead :) if you need help, feel free to reach out!

@AdityaBhate
Copy link
Contributor

thanks!

@AdityaBhate
Copy link
Contributor

Is this OK?
image

It looks cluttered, how about I rearrange them and move all the external links to a footer?
do you have any design in mind or should I do it?

(something like this?, it just a rough design)
image

@Idrinth
Copy link
Member Author

Idrinth commented Feb 18, 2024

It looks cluttered, how about I rearrange them and move all the external links to a footer? do you have any design in mind or should I do it?

I expected this to happen, would prefer keeping them up in the menu though. What about putting them in their own submenu? Similar to contributing

@AdityaBhate
Copy link
Contributor

ok...

@AdityaBhate
Copy link
Contributor

image
something like this?
or

image


I still prefer it like this tho
Screenshot 2024-02-18 121100

Sorry for asking too many questions 😅, (i am still trying out this code base and don't want to ruin it..)

@Idrinth
Copy link
Member Author

Idrinth commented Feb 18, 2024

The last one looks the best out of them, agreed. Maybe combine it with the first when the screen width gets smaller?

@AdityaBhate
Copy link
Contributor

ok,
will get it done and do a PR by tomorrow!

@Idrinth
Copy link
Member Author

Idrinth commented Feb 18, 2024

no hurry, it's not urgent. Thanks for helping!

@AdityaBhate
Copy link
Contributor

hey!
I added the LinkedIn group! and will push the code.
I also noticed that the website's navbar is not mobile-responsive.

after this issue is closed, can I create a new issue and make the navbar mobile responsive (using the hamburger menu)?

@Idrinth
Copy link
Member Author

Idrinth commented Feb 19, 2024

after this issue is closed, can I create a new issue and make the navbar mobile responsive (using the hamburger menu)?

yes, great! We made it functional for mobile, but didn't yet find time to add a way to minimize the menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation-website related to the project's website, not the framework documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants