Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format numbers in cli fixes #287 #289

Merged
merged 1 commit into from
Feb 8, 2024
Merged

format numbers in cli fixes #287 #289

merged 1 commit into from
Feb 8, 2024

Conversation

Idrinth
Copy link
Member

@Idrinth Idrinth commented Feb 8, 2024 •
edited
Loading

The Pull Request is ready

Framework

  • the change breaks no interface
  • default behaviour did not change
  • any new text output is added to the translation files (at least the english one)
  • tests have been added (if required)
  • documentation has been adjusted (if required)
  • shared code has been extracted in a different file

@Idrinth Idrinth marked this pull request as ready for review February 8, 2024 12:51
@Idrinth Idrinth merged commit 330227e into master Feb 8, 2024
10 of 14 checks passed
@Idrinth Idrinth deleted the format-numbers-for-cli branch February 8, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add thousand separators to cli output
1 participant
@Idrinth