Make idris-info-mode derived from help-mode and
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuse existing functionality from help-mode for navigating through history and buffer handling. Why: To reduce maintanance cost of maintaining own implementation and to improve user experience by relying on existing Emacs conventions.
keram
force-pushed
the
main-idris-info-to-help-mode
branch
from
be8f7d8
to
600c8f5
Compare
|
Great work! Can we have the BREAKING changes documented in the CHANGELOG. It would be good if there was a high-level summary of the brilliant work you have been doing on the mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reuse existing functionality from help-mode
for navigating through history and buffer handling.
Why:
To reduce maintanance cost of maintaining own implementation and to improve user experience by relying on
existing Emacs conventions.
For example provided key bindings
lrqby default to navigate through buffer history or close the buffer.Breaking changes
describe-function,describe-modeetc.)idris-info-quitdoes not anymore kill the info buffer. Instead it burries the buffer for later use and remove it's window or restore it's previous buffer (behaviour ofquit-window)