-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Source and Package Parser (Part 2) #113
Conversation
Hi @ziman, thanks for the feedback, those two points have been added to this merge request. |
Great, thanks! I've got some more questions, I'll put them as comments in the diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I can't see why the lexer works, but the CI symbol is green so I'm probably missing something.
d9ee738
to
e0f7e6f
Compare
Hey @ziman, I think this is way cleaner now, thanks for the feedback. |
d8e3138
to
d5aad58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got just a few naming suggestions, and maybe a proposal to merge Ident
and DotSepIdent
.
Otherwise I think it's good to go.
38c1cce
to
aa64ede
Compare
…actor Idris/Package Co-authored-by: Matus Tejiscak <ziman@functor.sk>
This has two commits, the first one refactors SourceToken a bit and the second one implements an (unpolished) Package Lexer/Parser and refactors Idris/Package.idr to use this new Lexer/Parser.
Feedback is appreciated. First part is #89.
One pro is that package names can now have dashes in their name UwU
Cleanup of SourceToken
There are many organizational and consistency changes, one of the more important ones being
Literal
being renameStringLit
to correspond withCharLit
,IntegerLit
,DoubleLit
and extracting more common code to Parser/Lexer/Common.Change to
ParseError tok
andParseError
ParseError tok
was renamedParsingError tok
andParseError
was refactored toParseError tok
to accept a token type.