Add symmetric and transitive closure relations #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gallais
reviewed
May 5, 2023
libs/base/Control/Relation.idr
Outdated
| public export | ||
| data TransClosure : Rel ty -> ty -> ty -> Type where | ||
| Nil : TransClosure rel x x | ||
| (::) : {x, y, z : ty} -> rel x y -> TransClosure rel y z -> TransClosure rel x z |
There was a problem hiding this comment.
I think you only need y : ty, the others can be runtime irrelevant because they're determined by the endpoints which can be made runtime-relevant if need be.
buzden
added a commit
to buzden/idris2-coop
that referenced
this pull request
May 10, 2023
buzden
added a commit
to buzden/Idris2
that referenced
this pull request
May 10, 2023
buzden
added a commit
to buzden/idris2-coop
that referenced
this pull request
May 10, 2023
buzden
added a commit
to buzden/idris2-coop
that referenced
this pull request
May 10, 2023
gallais
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SymClosureandTransClosurerelations, which take the symmetric and transitive closures of a given relation.