Updating server to return full url #7
Conversation
| individual.setValue("previewPath", "output/" + outputDir + "/index.html"); | ||
| individual.setValue("downloadPath", "output/" + outputDir + ".zip"); | ||
|
|
||
| individual.setValue("previewPath", contextURL + "/output/" + outputDir + "/index.html"); |
There was a problem hiding this comment.
Shall we change these to previewUrl and downloadUrl? Seeing as we're breaking backwards compatibility anyway, now would be the time to do it. Any thoughts @RFoley?
There was a problem hiding this comment.
Personally I think that would be a good idea, although we'd obviously have to update all the clients again.
There was a problem hiding this comment.
Sounds like a good idea, would make more sense now.
Could even just drop 'path' and have 'preview' & 'download'.
There was a problem hiding this comment.
My preference would be to include Url as it is more descriptive
There was a problem hiding this comment.
good point - @patricksheppard-IDR would you like to update?
There was a problem hiding this comment.
Will have to work on it tomorrow as it is getting late, but I can update that.
There was a problem hiding this comment.
Have updated to url
Version number needs updating, will do than in a separate commit.