-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#548 new email editor page #555
Feature/#548 new email editor page #555
Conversation
@Sinharitik589 Cool , it's look good , i like your approach to create new Model for Email |
required:true, | ||
}, | ||
emailVariables:{ | ||
type:Array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's reason to use this emailVariables ?
for custom email variable , we can use pattern {{client.name}} , then when we send email , we can replace those variable before sending mail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
…into feature/idurar#548-new-email-editor-page
required:true, | ||
}, | ||
emailVariables:{ | ||
type:Array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
Thank you @Sinharitik589 |
…ew-email-editor-page Feature/idurar#548 new email editor page
Description
Provide feature of editing the email templates providing user to set subject as well as body for the template
Major changes/addition:-
Related Issues
#548
Screenshots (if applicable)
Checklist