Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid dashboard due balance amount #787

Merged

Conversation

disalechinmay
Copy link
Contributor

Description

The due balance amount was previously considering only unpaid invoices.
It no considers partially paid invoices too.
Total due balance = (total of unpaid invoices) + [total of balance amount (invoice total - credit) on partially paid invoices]

Related Issues

#786

Steps to Test

  1. Go to the application.
  2. Create an invoice (example - $100).
  3. Register a partial payment (example - $30; current due = $100 - $30 = $70) against the invoice you created in above step.
  4. Validate the due balance shown on the dashboard (it should be $70 as long as there is no other invoice on the system).

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

@salahlalami salahlalami merged commit 4416f23 into idurar:dev Nov 9, 2023
1 check passed
@salahlalami
Copy link
Member

@disalechinmay Thank you

@disalechinmay disalechinmay deleted the issues/fix-invalid-dashboard-due-balance branch November 10, 2023 16:26
awesomedev82 pushed a commit to awesomedev82/idurar-erp-crm that referenced this pull request May 20, 2024
…ashboard-due-balance

Fixed invalid dashboard due balance amount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants