Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back button on Read email template #803

Merged

Conversation

rajatpandey441
Copy link
Contributor

@rajatpandey441 rajatpandey441 commented Nov 13, 2023

Description

For going back to the email templates list page, history.goBack() was used but history object was never defined. I replaced history.goBack() with navigate(/${entity.toLowerCase()}); which is working fine. This approach is also used while pressing Close button.

Related Issues

#802

Steps to Test

  1. Go to 'Settings'
  2. Click on 'Email Templates'
  3. Click on Dropdown in front of any email template > Show
  4. Click on back button
  5. Notice that, user can go back which was not working previously.

Screenshots (if applicable)

image

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

@salahlalami salahlalami merged commit d147256 into idurar:dev Nov 14, 2023
1 check passed
awesomedev82 pushed a commit to awesomedev82/idurar-erp-crm that referenced this pull request May 20, 2024
…ton-emailTemplate

fix: back button on Read email template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants