Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: display of the tag when the value is zero #857 #858

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix: display of the tag when the value is zero #857 #858

merged 1 commit into from
Dec 1, 2023

Conversation

Gregsai
Copy link
Contributor

@Gregsai Gregsai commented Dec 1, 2023

Description

The changes applied in this pull request standardize the display of tags whether the value is zero or not.

So, before the pull request, the null tags looked like this:
image

Now they look like this:
image

Technical Explanation :

Given that the moneyFormatter() function defines a default argument equal to 0 if the latter is not defined, it is not useful to check the state of "result?.total" before calling the function.

Related Issues

This PR is supposed to fix the issue : #857

Steps to Test

To test the solution:

  1. go to the dashboard
  2. place your cursor on one of the prices (null or non-null) of the summary thumbnails.
  3. Tags should all follow the same “currency price” format (ex: $ 0.00; $ 3,000.00)

Screenshots (if applicable)

image
image

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

@salahlalami salahlalami merged commit 7ca62f2 into idurar:dev Dec 1, 2023
1 check passed
@Gregsai Gregsai deleted the issues/fix-tag-value-when-equal-to-zero branch December 2, 2023 22:53
@Gregsai Gregsai restored the issues/fix-tag-value-when-equal-to-zero branch December 2, 2023 22:54
@Gregsai Gregsai deleted the issues/fix-tag-value-when-equal-to-zero branch December 2, 2023 22:55
awesomedev82 pushed a commit to awesomedev82/idurar-erp-crm that referenced this pull request May 20, 2024
…equal-to-zero

Fix: display of the tag when the value is zero idurar#857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants