Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: resolve admin create issue #984

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

slimskhab
Copy link
Contributor

Description

The purpose of this pull request (PR) is to address the issue related to creating admin accounts. In earlier versions, creating a new admin account necessitated sending a multipart request. However, in this updated version, the requirement for an image associated with the admin account has been eliminated. Consequently, the request now only needs to be a straightforward create request rather than a createAndUpload request.

Related Issues

#983

Steps to Test

  1. Login to the admin account using those credentials: email: admin@demo.com password: admin123
  2. Navigate to the settings page using sidebar
  3. Navigate tp the admin subcategory
  4. Try to add a new admin

Screenshots (if applicable)

Here is the video of @ngtalexander of the issue that he faced:
https://github.com/idurar/idurar-erp-crm/assets/12747343/f6d12977-321b-4f04-a1da-1e9c4d5839fd

Here is a video after the PR:
https://github.com/idurar/idurar-erp-crm/assets/12747343/e228a571-269e-4041-b008-6e2d603dfc77

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

@slimskhab slimskhab mentioned this pull request Mar 2, 2024
@salahlalami salahlalami merged commit 7aceaa9 into idurar:dev Mar 3, 2024
1 check passed
awesomedev82 pushed a commit to awesomedev82/idurar-erp-crm that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants