Adapt the column name from "date" to "time" #3
Conversation
|
!test |
2 similar comments
|
!test |
|
!test |
ckittl
force-pushed
the
ck/#2-adaptColumnScheme
branch
from
f918059
to
f7102b1
Compare
| @Column(name = "datum", nullable = false) | ||
| private ZonedDateTime date; | ||
| @Column(name = "time", nullable = false) | ||
| private ZonedDateTime time; | ||
|
|
||
| @Id | ||
| @ManyToOne(cascade = CascadeType.DETACH) |
There was a problem hiding this comment.
Don't know how you feel about this. As the many-to-one relation has no @JoinColumns annotation, it defaults back to coordinate_id, as this field ist named coordinate and the database id of CoordinateModel is id. However, this is quite implicit and I would like it to be more explicit.
|
|
||
| def curlByPR(String prId, String orgName, String repoName) { |
There was a problem hiding this comment.
I would rename prId to prNo as it is called in line 625 and the method extractPrNumber also indicate that it is the number we are actually after.
| String response = curlByPR(prNo, orgName, repoName) | ||
| log("i", "API response:" + response) | ||
| def jsonResponse = readJSON text: response | ||
| def branchName = jsonResponse.head.ref |
There was a problem hiding this comment.
Does this actually do the same thing as the old implementation?
|
Maybe you can have a short look at the Jenkinsfile changes and confirm that this works as I'm not too knowledgable there. Otherwise I would rename the databases and we can merge the changes. |
|
|
Resolves #1 (sorry for wrong branch naming).
Closing this pull request should only be done, after actual databases have been revised.