Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getAllUniqueCombinations avoid nested loops #432

Merged
merged 5 commits into from
May 28, 2024

Conversation

danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented May 14, 2024

resolves #431

@danielfeismann danielfeismann added bug Something isn't working enhancement New feature or request labels May 14, 2024
@danielfeismann danielfeismann added this to the Version 1.0 milestone May 14, 2024
@danielfeismann danielfeismann self-assigned this May 14, 2024
@danielfeismann danielfeismann marked this pull request as ready for review May 14, 2024 11:46
@danielfeismann danielfeismann requested review from staudtMarius and sebastian-peter and removed request for staudtMarius May 14, 2024 11:46
staudtMarius
staudtMarius previously approved these changes May 14, 2024
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit b6c1642 into dev May 28, 2024
3 checks passed
@danielfeismann danielfeismann deleted the df/#431_refactor-getAllUniqueCombinations- branch May 28, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor getAllUniqueCombinations
3 participants