-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring CsvFileConnector
and CsvDataSource
#1007
Labels
code quality
Code readability or structure is improved
Comments
FileNamingStrategy
from CsvFileConnector
CsvFileConnector
and CsvDataSource
staudtMarius
added a commit
that referenced
this issue
Mar 7, 2024
staudtMarius
added a commit
that referenced
this issue
Mar 14, 2024
staudtMarius
added a commit
that referenced
this issue
Apr 3, 2024
staudtMarius
added a commit
that referenced
this issue
Apr 9, 2024
sebastian-peter
added a commit
that referenced
this issue
Apr 12, 2024
staudtMarius
added a commit
that referenced
this issue
Apr 23, 2024
staudtMarius
added a commit
that referenced
this issue
May 1, 2024
…aSource # Conflicts: # CHANGELOG.md
staudtMarius
added a commit
that referenced
this issue
May 6, 2024
staudtMarius
added a commit
that referenced
this issue
May 16, 2024
staudtMarius
added a commit
that referenced
this issue
May 23, 2024
staudtMarius
added a commit
that referenced
this issue
Jun 4, 2024
staudtMarius
added a commit
that referenced
this issue
Jun 10, 2024
sebastian-peter
added a commit
that referenced
this issue
Jun 13, 2024
sebastian-peter
added a commit
that referenced
this issue
Jun 13, 2024
…Connector-and-CsvDataSource Refactor `CsvFileConnector` and `CsvDataSource`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What I think this should look like is
*Connector
s taking care of operations close to the file system, and*DataSource
handling higher-level decisions, i.e. where data is stored (paths/databases/etc.). WithSqlConnector
andSqlDataSource
, this division is already in place.Illustrating the desired change with examples in two areas:
CsvConnector
should then throw (or return withinTry
s)ConnectorException
s, andCsvDataSource
should throw (or return withinTry
s)SourceException
s.FileNamingStrategy
fromCsvFileConnector
Currently,
CsvFileConnector
uses theFileNamingStrategy
to determine paths of some entities. This is happening less with CsvDataSource should throw exceptions on error. #999, and should arguably move toCsvDataSource
anyways.CsvFileConnector
should not care where a path comes from, it should just deal with it.The text was updated successfully, but these errors were encountered: