Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CsvDataSource should throw exceptions on error. #999

Merged
merged 13 commits into from
Feb 7, 2024
Merged

CsvDataSource should throw exceptions on error. #999

merged 13 commits into from
Feb 7, 2024

Conversation

staudtMarius
Copy link
Member

Resolves #954

@staudtMarius staudtMarius added bug Something isn't working code quality Code readability or structure is improved labels Jan 30, 2024
@staudtMarius staudtMarius added this to the Version 4.2 milestone Jan 30, 2024
@staudtMarius staudtMarius self-assigned this Jan 30, 2024
@sebastian-peter sebastian-peter mentioned this pull request Jan 31, 2024
Merged
sebastian-peter
sebastian-peter requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made some changes to the code, please check out if it makes sense to you.

src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvDataSourceTest.groovy Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/utils/Try.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/source/csv/CsvIdCoordinateSource.java Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/source/csv/CsvIdCoordinateSource.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/source/csv/CsvWeatherSource.java Outdated Show resolved Hide resolved
@staudtMarius staudtMarius mentioned this pull request Feb 2, 2024
Open
@sebastian-peter sebastian-peter mentioned this pull request Feb 6, 2024
Closed
@sebastian-peter sebastian-peter merged commit 471f865 into dev Feb 7, 2024
4 checks passed
@sebastian-peter sebastian-peter deleted the ms/#954-CsvDataSource-should-throw-exceptions-on-error branch February 7, 2024 09:22
@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
@sebastian-peter sebastian-peter mentioned this pull request Feb 12, 2024
Open
danielfeismann added a commit that referenced this pull request Mar 11, 2024
@danielfeismann
Merge pull request #1048 from ie3-institute/to/#999-doc-fix
87bfe29 
Fix line.md documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@staudtMarius staudtMarius

Labels
bug Something isn't working code quality Code readability or structure is improved
Projects
None yet
Milestone
Version 5.0
Development

Successfully merging this pull request may close these issues.

CsvDataSource should throw exceptions on error
2 participants
@staudtMarius @sebastian-peter