Asset type input factories

[sebastian-peter]

Addresses parts of #16

[codecov]

Codecov Report

Merging #26 into master will increase coverage by 0.79%.
The diff coverage is 62.71%.

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
+ Coverage     32.58%   33.37%   +0.79%     
- Complexity      283      297      +14     
============================================
  Files           114      118       +4     
  Lines          2434     2514      +80     
  Branches        406      416      +10     
============================================
+ Hits            793      839      +46     
- Misses         1618     1650      +32     
- Partials         23       25       +2

Impacted Files	Coverage Δ	Complexity Δ
.../models/input/thermal/CylindricalStorageInput.java	0% <0%> (ø)	0 <0> (?)
src/main/java/edu/ie3/io/FileNamingStrategy.java	88.23% <100%> (ø)	18 <0> (ø)	⬇️
src/main/java/edu/ie3/models/StandardUnits.java	95.45% <100%> (+0.33%)	1 <0> (ø)	⬇️
...ain/java/edu/ie3/io/processor/EntityProcessor.java	87.5% <100%> (+2.08%)	17 <0> (+2)	⬆️
.../ie3/models/result/thermal/ThermalHouseResult.java	26.66% <26.66%> (ø)	2 <2> (?)
...odels/result/thermal/CylindricalStorageResult.java	46.66% <46.66%> (ø)	3 <3> (?)
...e3/models/result/thermal/ThermalStorageResult.java	46.66% <46.66%> (ø)	3 <3> (?)
...u/ie3/models/result/thermal/ThermalUnitResult.java	46.66% <46.66%> (ø)	3 <3> (?)
...u/ie3/models/result/thermal/ThermalSinkResult.java	50% <50%> (ø)	1 <1> (?)
...du/ie3/io/factory/result/ThermalResultFactory.java	81.81% <81.81%> (ø)	7 <7> (?)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5eba5a...fb4a915. Read the comment docs.

[johanneshiry]

Really good work and nice to read code.

Added some remarks on things that where unclear to me as well as some stylistic stuff.
Willing to merge if these things are resolved.

Thank you for the good work! 👍

[sebastian-peter]

It would be nice if this branch could be merged soon, as I spend most of my day today merging ever-new changes from master.

There is a problem now within SystemParticipantTypeInputFactory because ChpTypeInput now needs ThermalStorageInput to be built. I guess this is a case for a special complex entity factory, but probably we should talk about this beforehand.

[johanneshiry]

It would be nice if this branch could be merged soon, as I spend most of my day today merging ever-new changes from master.

There is a problem now within SystemParticipantTypeInputFactory because ChpTypeInput now needs ThermalStorageInput to be built. I guess this is a case for a special complex entity factory, but probably we should talk about this beforehand.

Thanks for your work. I'll merge it now and opened a new issue for the ChpTypeInput (see #39). Please let me know when you're in office again so that we can talk about that.