You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the tests of in the Transformer2wTypeConverterSpec shouldn't pass as the values the actual calculated result is compared against seems to be wrongly parameterized.
For the conductance (gM) the result (as per my pen and paper calculations and implementation of the parameter calculation for the powerfactory2psdm converter) should actually be a third of the noted 2480.5790 nS.
Why do the test pass:
We compare the difference of actual and expected result against the testing tolerance. As we miss to take the absolute value of that difference the tests conveniently still passes when the expected result is much greater than the actual result.
The text was updated successfully, but these errors were encountered:
Some of the tests of in the
Transformer2wTypeConverterSpec
shouldn't pass as the values the actual calculated result is compared against seems to be wrongly parameterized.For the conductance (gM) the result (as per my pen and paper calculations and implementation of the parameter calculation for the powerfactory2psdm converter) should actually be a third of the noted 2480.5790 nS.
Why do the test pass:
We compare the difference of actual and expected result against the testing tolerance. As we miss to take the absolute value of that difference the tests conveniently still passes when the expected result is much greater than the actual result.
The text was updated successfully, but these errors were encountered: