Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty tests in Transformer2wTypeConverterSpec #43

Closed
t-ober opened this issue Jun 30, 2021 · 0 comments · Fixed by #60
Closed

Faulty tests in Transformer2wTypeConverterSpec #43

t-ober opened this issue Jun 30, 2021 · 0 comments · Fixed by #60
Labels
bug Something isn't working
Projects

Comments

@t-ober
Copy link
Contributor

t-ober commented Jun 30, 2021

Some of the tests of in the Transformer2wTypeConverterSpec shouldn't pass as the values the actual calculated result is compared against seems to be wrongly parameterized.

For the conductance (gM) the result (as per my pen and paper calculations and implementation of the parameter calculation for the powerfactory2psdm converter) should actually be a third of the noted 2480.5790 nS.

Why do the test pass:

We compare the difference of actual and expected result against the testing tolerance. As we miss to take the absolute value of that difference the tests conveniently still passes when the expected result is much greater than the actual result.

@t-ober t-ober added the bug Something isn't working label Jun 30, 2021
@t-ober t-ober added this to Needs triage in BugTracker via automation Jun 30, 2021
BugTracker automation moved this from Needs triage to Closed Jul 21, 2021
ckittl added a commit that referenced this issue Jul 21, 2021
Fix wrongly implemented test for two winding transformer type conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
BugTracker
  
Closed
Development

Successfully merging a pull request may close this issue.

1 participant