Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unique generation of ActorNames #103

Open
johanneshiry opened this issue Jan 20, 2022 · 2 comments · May be fixed by #523
Open

Fix unique generation of ActorNames #103

johanneshiry opened this issue Jan 20, 2022 · 2 comments · May be fixed by #523
Assignees
@johanneshiry @danielfeismann
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@johanneshiry
Copy link
Member

johanneshiry commented Jan 20, 2022 •
edited

On very large datasets the current implementation of the actor naming uuid tends to be not unique anymore. Therefore we need to find an alternative for the unique name generation.

Possible approaches:

  • remove substring(0,8) (might clutter logs...)
  • find another method to generate unique identifiers (maybe hash values?

Affected line:
Clipboard - 19 Januar 2022 17_03
@johanneshiry johanneshiry added the bug Something isn't working label Jan 20, 2022
@johanneshiry johanneshiry added this to the Version 2.1.0 milestone Jan 20, 2022
@johanneshiry johanneshiry self-assigned this Jan 20, 2022
@danielfeismann danielfeismann self-assigned this Feb 7, 2022
@sebastian-peter sebastian-peter added the good first issue Good for newcomers label Oct 12, 2022
@sebastian-peter sebastian-peter removed this from the Version 3.0 milestone Feb 17, 2023
@vickybung1 vickybung1 linked a pull request May 9, 2023 that will close this issue
Open
@t-ober
Copy link
Contributor

t-ober commented May 9, 2023

The system participants are built with

    def simonaActorOf(props: Props, actorId: String): ActorRef =
      refFactory.actorOf(props, actorName(props, actorId))

where the actorId is used. Find out what we want here.

@sebastian-peter
Copy link
Member

Ids (which are name-like a lot of times, in my experience) have to be unique as well, maybe that's a way to consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanneshiry johanneshiry

@danielfeismann danielfeismann

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed implementation of actor naming ie3-institute/simona
4 participants
@sebastian-peter @johanneshiry @t-ober @danielfeismann