Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed implementation of actor naming #523

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Conversation

vickybung1
Copy link
Contributor

Resolves #103

@sebastian-peter
Copy link
Member

As hinted to in #103, I would like an actor name generation better that is using more meaningful names (not less, as the generation time in nanoseconds has no meaning to the actor). Maybe we can use system participant ids here, if possible?

@sebastian-peter
Copy link
Member

!test

@danielfeismann danielfeismann self-assigned this Jul 12, 2024
@danielfeismann danielfeismann added the enhancement New feature or request label Jul 12, 2024
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the random number wouldn't even be necessary per this PR, but it doesn't hurt either.
Could you take care of the code smell before we merge this @danielfeismann ?

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's finally get this in

@sebastian-peter sebastian-peter merged commit df66ad2 into dev Aug 14, 2024
3 of 4 checks passed
@sebastian-peter sebastian-peter deleted the vb/#103_ActorNames branch August 14, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unique generation of ActorNames
3 participants