Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken style of references by separating publications and references #501

Closed
wants to merge 9 commits into from
Closed

Fix broken style of references by separating publications and references #501

wants to merge 9 commits into from

Conversation

danielfeismann
Copy link
Member

resolves #500

@danielfeismann danielfeismann added the documentation Improvements or additions to documentation label Apr 6, 2023
@danielfeismann danielfeismann self-assigned this Apr 6, 2023
@danielfeismann danielfeismann marked this pull request as ready for review April 6, 2023 12:51
sebastian-peter
sebastian-peter reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. However, both pages still seem broken at the top right... Maybe there's also a solution to this?

grafik

@sebastian-peter
Copy link
Member

sebastian-peter commented Apr 6, 2023 •
edited
Loading

Somehow, the footer moved up a bunch of levels in DOM hierarchy. Should normally be somewhere within the wy-grid-for-nav-element

grafik

I think that's what's caused the error in the first place

@danielfeismann
Copy link
Member Author

Somehow, the footer moved up a bunch of levels in DOM hierarchy. Should normally be somewhere within the wy-grid-for-nav-element

grafik

I think that's what's caused the error in the first place

Thanks, think you're right. Seems to be a problem with docutils 0.18 rtd#1411. Maybe we should rollback to Sphinx 5.1.3?

@danielfeismann
Copy link
Member Author

Closed, temp solved by #504 and tracked by #505

@sebastian-peter sebastian-peter deleted the df/#500_fix_rtd_references branch April 25, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter left review comments

Assignees

@danielfeismann danielfeismann

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix style of references in RTD
2 participants
@danielfeismann @sebastian-peter