IEEE-209: Added acknowledgment form and participant onboarding #430
Conversation
YuYing-Liang
changed the title
…ackathon-template into IEEE-209-acknowledgement-page
YuYing-Liang
requested review from
EthanHugh,
KarandeepLubana and
dalshekerchi
|
Email checks failing, pls ignore for now |
There was a problem hiding this comment.
create a normal user ✅
login as them into the HSS with these situations:
- when the user hasn't completed their application, the page should show an incomplete status message ❌
- when the user has been waitlisted (yellow alert) or rejected (red alert), they should see appropriate messages for those review statuses ✅
- when the user has been accepted they should see a green message box with a "Get Started" button ✅
- click that button and it should bring up the acknowledgement form ✅
- A popup should appear when you click "Waiver of Liability and Hold Harmless Agreement" which has the contents of the waiver ✅
- you need to check everything on the form & input an e signature to enable the "Continue" button ✅
- If the user hasn't RSVP'd to the event then an error should appear ✅
- If the user has RSVP'd then they should see a success message with their name and team code and a link to go to their dashboard page ✅
Haven't found any other buggs yet other than the first one.
| import Typography from "@material-ui/core/Typography/Typography"; | ||
| import { hackathonName } from "constants.js"; | ||
|
|
||
| const Waver = ( |
There was a problem hiding this comment.
Consider using MUI dialog? then we will have the transition animation without using react-transition-group
There was a problem hiding this comment.
the waiver uses teh mui modal component and isn't attached to any transition group, the acknowledgement form is part of the transition though
|
|
||
| export const UserHasBeenGrantedAccessMessage = () => ( | ||
| <> | ||
| <Typography variant="h1"> |
There was a problem hiding this comment.
Styling can be improved. I can make the Figma design if necessary.
| <Grid container justifyContent="center"> | ||
| <Grid item lg={6} xs={12}> | ||
| <Card style={{ padding: "15px 5px" }}> | ||
| <Typography style={{ fontSize: "25px" }} align="center"> |
There was a problem hiding this comment.
Styling can be improved. I can make the Figma design if necessary.
Minor thing: we can capitalize the first letter of user's name so that it looks professional. Sometimes when user fills their application, they don't pay attention to the capital letter. (i.e I applied with my name as leo li, and on the website, it should display Leo there to make it look nice).
| userAcceptance: { | ||
| user: null, | ||
| isLoading: false, | ||
| error: null, |
There was a problem hiding this comment.
We need to add a new field to record the application state? Bcz review_state will appear only if there is a review record in the database. If the user hasn't submitted their application, they won't be able to have the review_state
There was a problem hiding this comment.
And that might be the reason why we are failing the first step as I mentioned in my comment
| } catch (e: any) { | ||
| dispatch( | ||
| displaySnackbar({ | ||
| message: `Failed to grant permissions to Hardware Signout Site: Error ${e.response.status}`, |
There was a problem hiding this comment.
The message is kinda confusing from my view: something like "failed when granting permissions to *** to access HSS" would be a choice.
|
@Leo6Leo thanks for the review! I'm going to hold off on styling changes right now because of the urgency of this ticket, other feedback as been addressed though! Also, try to be more descriptive when you say "Styling can be improved" I know you mention you can re-design it but maybe add more comments about the design to give the developer an idea of what they should change. |
Overview
Unit Tests Created
Steps to QA
- when the user hasn't completed their application, the page should show an incomplete status message
- when the user has been waitlisted (yellow alert) or rejected (red alert), they should see appropriate messages for those review statuses
- when the user has been accepted they should see a green message box with a "Get Started" button
- click that button and it should bring up the acknowledgement form
- A popup should appear when you click "Waiver of Liability and Hold Harmless Agreement" which has the contents of the waiver
- you need to check everything on the form & input an e signature to enable the "Continue" button
- If the user hasn't RSVP'd to the event then an error should appear
- If the user has RSVP'd then they should see a success message with their name and team code and a link to go to their dashboard page