Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indication on whether a WSON node is 'Reconfigurable or not' #1

Closed
haomianzheng opened this issue Apr 15, 2020 · 3 comments · Fixed by #3
Closed

Indication on whether a WSON node is 'Reconfigurable or not' #1

haomianzheng opened this issue Apr 15, 2020 · 3 comments · Fixed by #3

Comments

@haomianzheng
Copy link
Member

This is related with another comments from ietf-layer0-types.
ietf-ccamp-wg/draft-ietf-ccamp-layer0-types#6

According to the conclusion of this issue, the node type won't be specified in ietf-layer0-types (as they are WSON-specific, not L0-general). There will be a new leaf 'is-reconfigurable-node', in type boolean, in the WSON topology module to indicate whether the WSON node is reconfigurable or not.

Setting to 1 means reconfigurable, as a ROADM; while setting to 0 means not reconfigurable, as a FOADM.

@haomianzheng
Copy link
Member Author

Proposal as follow:

OLD
grouping wson-node-attributes {
description "WSON node attributes";
container wson-node {
description "WSON node attrtibutes";
leaf node-type {
type identityref {
base layer0-types:layer0-node-type;
}
description "WSON node type";
}
}
}

NEW
grouping wson-node-attributes {
description "WSON node attributes";
container wson-node {
description "Candidate type: ROADM or FOADM";
leaf is-reconfigurable-node {
type boolean;
description
"true - ROADM,
false - FOADM. ";
}
}
}

@italobusi
Copy link
Member

italobusi commented Apr 15, 2020

Some proposed changes:

  1. Some editorial changes
  2. make the definition more generic and applicable also to abstract TE nodes
  3. add a default value
  4. define the wson-node as a presence container: Comments on layer0-node-type draft-ietf-ccamp-layer0-types#6 (comment)
  grouping wson-node-attributes {
    description "WSON node attributes";
    container wson-node {
      presence "The TE node is a WSON node.";
      description "WSON node attributes";
      leaf is-reconfigurable-node {
        type boolean;
        default true;
        description
          "Indicates whether the WSON node is reconfigurable:
           - true: the node is reconfigurable
             (e.g., it is representing a ROADM node);
           - false: the node is not reconfigurable
             (e.g., it is representing a FOADM node).";
      }
    }
  }

@italobusi italobusi linked a pull request Apr 16, 2020 that will close this issue
@italobusi
Copy link
Member

I think PR #3 is addressing this issue

I have linked this open issue with PR#3 so it will be automatically closed when the PR#3 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants