Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity modulation : add new modulation formats. #41

Closed
ggalimba56 opened this issue May 18, 2022 · 4 comments · Fixed by #53
Closed

identity modulation : add new modulation formats. #41

ggalimba56 opened this issue May 18, 2022 · 4 comments · Fixed by #53
Assignees
Labels
enhancement New feature or request IETF-114 issue to be closed with PR for IETF-114

Comments

@ggalimba56
Copy link

The identity modulation is covering almost all modulation formats.
My proposal is to complete the list adding:

  • DPSK (Differential Phase Shift Keying)
  • QAM32
  • DP-QAM32
  • QAM64
  • DP-QAM64
  • HYBRID modulation format (see also Hybrid Modulation format #47)
  • probabilistic shaping modulation format

Further description will be provided to the above list.

@ggalimba56 ggalimba56 added the enhancement New feature or request label May 18, 2022
@ggalimba56 ggalimba56 self-assigned this May 18, 2022
@egriseri
Copy link

@ggalimba56 for sure we can't fully cover all the modulation formats. I also noticed that we included dual carrier format, and this opens to additional complexity (let's imagine a 4 carrier format, and so on)
Anyway, for the probabilistic shaping we can specify the "base" format as 8QAM, 16QAM, 32QAM, 64QAM but I really doubt we should specify the entropy value. What do you think?

@sergiobelotti
Copy link
Contributor

sergiobelotti commented May 24, 2022

Call on 05/24/22:
The proposal from Gabriel is to add the first 4 modulation formats listed above and leave a part the last two for the moment.
AP @ggalimba56 Gabriele: to introduce description on the 4 modulation format above and a standard reference (if exists)

@sergiobelotti sergiobelotti added the IETF-114 issue to be closed with PR for IETF-114 label May 24, 2022
@ggalimba56
Copy link
Author

Here a possible proposal:

identity DPSK {
base modulation;
description
“DPSK (Differential Phase Shift Keying) modulation";
}

identity QAM32 {
base modulation;
description
"QAM32 (32 symbols Quadrature Amplitude Modulation)";
}

identity DP-QAM32 {
base modulation;
description
"DP-QAM32 (32 symbols Dual Polarization Quadrature Amplitude
Modulation)";
}

identity QAM64 {
base modulation;
description
"QAM64 (64 symbols Quadrature Amplitude Modulation)";
}

identity DP-QAM64 {
base modulation;
description
"DP-QAM64 (64 symbols Dual Polarization Quadrature Amplitude
Modulation)";
}

@sergiobelotti
Copy link
Contributor

@ggalimba56 @egriseri : do you know if a standard reference exists to be added in the description?

italobusi added a commit that referenced this issue Jun 29, 2022
YANG model updates for IETF 114

Fix #41, #42, #43, #44, #45, #46, #48, #49, #50 and #51
italobusi added a commit that referenced this issue Jun 29, 2022
YANG model updates for IETF 114

Fix #41, fix #42, fix #43, fix #44, fix #45, fix #46, fix #48, fix #49, fix #50 and fix #51

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>
italobusi added a commit that referenced this issue Jul 6, 2022
* YANG model updates

YANG model updates for IETF 114

Fix #41, fix #42, fix #43, fix #44, fix #45, fix #46, fix #48, fix #49 and fix #50

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request IETF-114 issue to be closed with PR for IETF-114
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants