Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add needed standard reference #6

Closed
sergiobelotti opened this issue Sep 28, 2020 · 4 comments · Fixed by #100
Closed

Add needed standard reference #6

sergiobelotti opened this issue Sep 28, 2020 · 4 comments · Fixed by #100
Assignees
@ggrammel @dieterbeller
Labels
help wanted Extra attention is needed YANG update

Comments

@sergiobelotti
Copy link
Contributor

sergiobelotti commented Sep 28, 2020 •
edited
Loading

More references are needed to where attributes and identities are defined. Need to review and add where is needed the correct reference.

Please see related comment #4 (review).
@ggrammel
Copy link

Google found found below table here: https://www.snia.org/technology-communities/sff/specifications?field_doc_status_value=All&combine=module+management&field_release_date_value_2%5Bvalue%5D%5Bdate%5D=&field_release_date_value%5Bvalue%5D%5Bdate%5D=&items_per_page=20&captcha_sid=2344903&captcha_token=e14eae6c0df19f04e569aeb8e09b97a3

Standards.pdf

Assume all of those have their own definitions, but perhaps not all are relevant for WDM. Is anyone of the optical experts aware of those?

@italobusi
Copy link
Member

List of definitions or standard references to be provided:

Co-authored-by: sergio belotti sergio.belotti@nokia.com

@italobusi italobusi added the help wanted Extra attention is needed label Dec 1, 2023
italobusi added a commit that referenced this issue Dec 5, 2023
@italobusi @sergiobelotti
Additional changes:
3448375 
- Fixed some standard references: see #6
- Added frequency and power range attributes to Standard Mode: fix #10
- Added text to clarify the WDM label description: fix #5

---

Co-authored-by: sergio belotti <sergio.belotti@nokia.com>
@italobusi italobusi mentioned this issue Dec 5, 2023
Merged
italobusi added a commit that referenced this issue Jan 23, 2024
@italobusi @sergiobelotti
Updates for WG LC preparation: (#82)
508a00d 
* Initial updates for WG LC preparation:

- renamed decimal-16-digits and decimal-16-digits-or-null as power-spectral-density and power-spectral-density-or-null: see ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#160
- added ratio-in-db and ratio-in-db-or-null: see ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#160
- Shortened types and attribute names
   - power-spectral-density -> psd
   - power-spectral-density-or-null -> psd-or-null
   - power-in-dbm -> power-dbm
   - power-in-dbm-or-null -> power-dbm-or-null
   - decimal-2-digits -> decimal-2
   - decimal-2-digits-or-null -> decimal-2-or-null
   - decimal-5-digits -> decimal-5
   - decimal-5-digits-or-null -> decimal-5-or-null
   - ratio-in-db -> power-ratio
   - ratio-in-db-or-null -> power-ratio-or-null
   - gain-in-db -> power-gain
   - gain-in-db-or-null -> power-gain-or-null
   - loss-in-db -> power-loss
   - loss-in-db-or-null -> power-loss-or-null
- Fixed some standard references: see #6
- Added frequency and power range attributes to Standard Mode: fix #10
- Added text to clarify the WDM label description: fix #5

---

Co-authored-by: sergio belotti <sergio.belotti@nokia.com>
@italobusi
Copy link
Member

Updated list of definitions or standard references to be provided:

  • modulation format;
  • Power mode
  • SNR and GSNR
  • PSD
  • PMD
  • Penalty Loss (PL)

@ggrammel
Copy link

  • modulation format: doesn't seem to have a definition. The best reference I could find was G.Sup39

This edition adds further information on modulation formats;
clarifies power budget parameters for systems with optical amplifiers; provides further information on
the optical signal-to-noise ratio (OSNR) measurement;

  • Power mode: This is about operating Amplifiers which AFAIK are not subject to Standardization in ITU-T
  • OSNR can again be found inG.Sup39 but it's rather a description. G.977.1 also refers to the earlier but has a better definition. Suggest to use G.977.1 as a reference.
  • GSNR is defined in G.977.1
  • PSD G.9700
  • PMD G.666
  • Penalty Loss (PL): Don't think there is an ITU-T definition of it as the term alone looks quite "sloppy". Could not find a good reference

italobusi added a commit that referenced this issue Apr 30, 2024
@italobusi @sergiobelotti
Added references: fix #6
1c6dcae 
---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>
@italobusi italobusi mentioned this issue Apr 30, 2024
Merged
sergiobelotti added a commit that referenced this issue May 28, 2024
@italobusi @sergiobelotti
WG LC preparation (step 4) (#100)
52f94ef 
* Changed operational-mode to be string

Fix ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#172

---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>

* Added references: fix #6

---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>

* Added keys to the lists

See: ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#167

---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>

* Aligned title and abstract with RFC8776 and L1-Types: fix #99

---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>

* Addressed some of the comments from Adrian

See #98

---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>

* Updated cd-value, pmd-value, pdl-value and rx-channel-power-value not to use the EMPTY value and to be keys for the penalty lists

Removed range for cd-value

---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>

* Removed the description of the cd-pmd-penalty grouping which has been removed from the YANG file

---

Co-Authored-By: sergio belotti <sergio.belotti@nokia.com>

---------

Co-authored-by: sergio belotti <sergio.belotti@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggrammel ggrammel

@dieterbeller dieterbeller

Labels
help wanted Extra attention is needed YANG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WG LC preparation (step 4) ietf-ccamp-wg/ietf-ccamp-layer0-types-ext-RFC9093-bis
4 participants
@italobusi @sergiobelotti @ggrammel @dieterbeller