Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ietf-layer0-types-ext to resolve some issues #25

Merged
merged 6 commits into from Jun 15, 2021
Merged

Conversation

italobusi
Copy link
Member

@italobusi italobusi commented Apr 9, 2021

Moving type-power-mode, fiber-type and frequency-range definitions from optical impairments

Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#54

Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#58

Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#68 (comment)

Co-authored-by: sergiobelotti sergio.belotti@nokia.com

sergiobelotti and others added 5 commits March 23, 2021 12:53
changes addressing issues #41 and #42on draft-ietf-ccamp-optical-impairment-topology
Co-authored-by: italobusi <italo.busi@huawei.com>
Moving type-power-mode, fiber-type and frequency-range definitions from optical impairments

Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#54

Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#54

Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#68 (comment)

Co-authored-by: sergiobelotti <sergio.belotti@nokia.com>
italobusi added a commit to ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang that referenced this pull request Apr 9, 2021
Align with ietf-ccamp-wg/ietf-ccamp-layer0-types-ext-RFC9093-bis#25

Co-Authored-By: sergiobelotti <sergio.belotti@nokia.com>
ietf-layer0-types-ext.yang Show resolved Hide resolved
ietf-layer0-types-ext.yang Show resolved Hide resolved
Copy link
Contributor

@agva123 agva123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two possible points to improve

Addressing Esther and Aihua review comments:
- #25 (comment)
- #25 (comment)
Copy link
Contributor

@agva123 agva123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the must statement with current()

@italobusi italobusi requested a review from agva123 June 11, 2021 21:29
@italobusi italobusi merged commit 3bc2cdb into master Jun 15, 2021
@italobusi italobusi deleted the to-IETF-111 branch June 15, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move type-power-mode identities to the layer0-types-ext? Move fiber-type identities to the layer0-types-ext?
4 participants