New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ietf-layer0-types-ext to resolve some issues #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes addressing issues #41 and #42on draft-ietf-ccamp-optical-impairment-topology
Co-authored-by: italobusi <italo.busi@huawei.com>
Moving type-power-mode, fiber-type and frequency-range definitions from optical impairments Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#54 Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#54 Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#68 (comment) Co-authored-by: sergiobelotti <sergio.belotti@nokia.com>
italobusi
added a commit
to ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang
that referenced
this pull request
Apr 9, 2021
Align with ietf-ccamp-wg/ietf-ccamp-layer0-types-ext-RFC9093-bis#25 Co-Authored-By: sergiobelotti <sergio.belotti@nokia.com>
agva123
requested changes
Jun 8, 2021
agva123
reviewed
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two possible points to improve
Addressing Esther and Aihua review comments: - #25 (comment) - #25 (comment)
1 task
agva123
reviewed
Jun 10, 2021
agva123
reviewed
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the must statement with current()
EstherLerouzic
approved these changes
Jun 14, 2021
agva123
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving type-power-mode, fiber-type and frequency-range definitions from optical impairments
Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#54
Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#58
Resolve ietf-ccamp-wg/draft-ietf-ccamp-optical-impairment-topology-yang#68 (comment)
Co-authored-by: sergiobelotti sergio.belotti@nokia.com