Ben's AD review comments #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original text was superceded since written and was thus very badly wrong.
kaduk
reviewed
Mar 13, 2020
| A team with administrator access SHOULD be created for the Working Group Chairs | ||
| and any Working Group Secretary. Administrator access is preferable, since this | ||
| does not also include the ability to push to all repositories and ownership does | ||
| not grant any other significant privileges. |
There was a problem hiding this comment.
I can understand that there's not a huge need to mention the details of Administrator privilege in these guidelines.
There was a problem hiding this comment.
Well, the point was that this was flat wrong, based on an outdated authorization model.
There was a problem hiding this comment.
Should we mention that the model (as is now documented) is also subject to change?
Co-Authored-By: kaduk <kaduk-github@mit.edu>
chris-wood
reviewed
Mar 13, 2020
chris-wood
reviewed
Mar 13, 2020
chris-wood
approved these changes
Mar 13, 2020
Co-Authored-By: Christopher Wood <caw@heapingbits.net>
Based on Rob's review feedback, but adding it here to avoid conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.