Update twotypes-env.txt #347
Conversation
|
Circlecl fails to build but it builds successfully on my local machine. Someone familiar with circlecl should take a look. |
See martinthomson/i-d-template#293 TL;DR drop CircleCI and move to GitHub Actions :-) |
It's not that simple, as I'm finding with another repo. |
|
But, about the proposed change to the diagram. |
It's not made explicit In the PR, but Ned's patch addresses issue #344. Maybe let's discuss there, in particular if you don't think it's an issue worth fixing. |
|
I'll take on the editorial task to align the diagram with the intended proposal for change here, if this does not work out-of-the-box in the current tool chain. Are there any objections with my assessment that this is again just an editorial fix: in this case we are aligning a diagram to reflect text better? If there are no counter indications, I'll fix this next week¹ [¹] soon (tm) |
|
This kinda got old and we'll discuss it at the next editor's meeting. |
|
fixes #344 |
|
If tweaking this diagram, the "Collect Claims" arrow could be misinterpreted as Target sending claims to AE. If arrow text was "Collected Claims" then its less likely to be misinterpreted. |
henkbirkholz
removed
the
wontfix
|
I have added this diagram as a second digram, and moved the diagram to the end of section 3. |
| ## Environment Interactions | ||
|
|
||
| As explained in the sections below, the Attesting Environment may be arbitrarily complex. | ||
| It may be distributed in various ways, or may depend upon other environments that collect claims on the environment itself as part of the process. |
There was a problem hiding this comment.
What does "distributed" mean here? Distributing code for an attester? Maybe pick another term?
| | .-------------. .-------------. | | ||
| | | Attesting | | Other | | | ||
| | | Environment |<------------| Attesting | | | ||
| | | | Evidence | Environment | | |
There was a problem hiding this comment.
Is this Evidence different from the Evidence in the vertical arrow?
Assuming so, then Evidence' or Evidence 2 would be more clear, but either way the text discussing the diagram should explain what happens with this Evidence, since right now I don't understand this diagram.
Added an optional attesting environment that supplies evidence to a lead attesting env.