Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile or eat_profile? #4

Closed
laurencelundblade opened this issue May 25, 2022 · 8 comments · Fixed by #11
Closed

profile or eat_profile? #4

laurencelundblade opened this issue May 25, 2022 · 8 comments · Fixed by #11

Comments

@laurencelundblade
Copy link
Collaborator

This doc refers to both "profile" and "eat_profile". EAT itself uses both terms, the first for the CBOR claim and the second for the JSON claim (because "profile" is already registered in JWT).

I think we either need to fix EAT so it just uses "eat_profile", or explain the mixing of terms in this document.

@henkbirkholz
Copy link
Member

If we want that consistency, I agree that this problem ports back to the EAT I-D.

@laurencelundblade
Copy link
Collaborator Author

It is the way it is in EAT for a reason. It's not just a sloppy error.

It is to be consistent with all the other EAT claims that don't start with "eat_".

@thomas-fossati
Copy link
Collaborator

sure, I didn't question that :-) I did 👍 since renaming it to eat_profile in CBOR is just cosmetic change, so it seems quite cheap.

@thomas-fossati
Copy link
Collaborator

@laurencelundblade can this be closed?

@laurencelundblade
Copy link
Collaborator Author

EAT is now consistent and uses only "eat_profile". Should this draft name the Optional parameter "eat_profile" to be consistent?

@thomas-fossati
Copy link
Collaborator

all media type names we define start with application/eat-. To me that seems to provide enough context to avoid ambiguity; it also stutters less. That said, if you are keen on consistency I am not opposed to prepend eat_.

@henkbirkholz
Copy link
Member

eat_profile seems consistent to me.

@thomas-fossati
Copy link
Collaborator

ok, consistence beats minimalism then :-)

thomas-fossati added a commit that referenced this issue Oct 17, 2022
* rename the media-type parameter from `profile` to `eat_profile`
* DEB (the acronym) is no more
* add refs to REST design documents for HTTP and CoAP
* two edits suggested by Carl and Dave

also:

* add line RFC8792 line folding in HTTP examples
* add a changelog

Fix #4
Fix #7
Fix #8
Fix #9

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
thomas-fossati added a commit that referenced this issue Oct 19, 2022
* rename the media-type parameter from `profile` to `eat_profile`
* DEB (the acronym) is no more
* add refs to REST design documents for HTTP and CoAP
* two edits suggested by Carl and Dave

also:

* add line RFC8792 line folding in HTTP examples
* add a changelog

Fix #4
Fix #7
Fix #8
Fix #9

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants