Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp in uppercase? #1263

Closed
mwelzl opened this issue Sep 5, 2023 · 5 comments · Fixed by #1435
Closed

tcp in uppercase? #1263

mwelzl opened this issue Sep 5, 2023 · 5 comments · Fixed by #1435
Assignees

Comments

@mwelzl
Copy link
Contributor

mwelzl commented Sep 5, 2023

From the review by Éric Vyncke:

Section 4.1

Should 'tcp' be in uppercase in tcp Connection could support ?

@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 17, 2023

#1404 will clarify that property names are case-insensitive. I like lowercase tcp here for style, and also because it somehow stresses that we're talking about a property name and not TCP per se (we do use TCP in the same sentence for that, so I think it's nice to have that distinction).

=> I propose to close this without action.

@mwelzl mwelzl added the wontfix This will not be worked on label Oct 17, 2023
@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 17, 2023

To be fixed: should be "Connection using TCP" (so Connection is used right, and TCP capitalized here but not below)

@mwelzl mwelzl self-assigned this Oct 17, 2023
@mwelzl mwelzl removed the wontfix This will not be worked on label Oct 17, 2023
@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 27, 2023

This is now fixed - I missed which PR did it, but the text does now say "e.g., a tcp Connection could support a TCP-specific Transport Property, such as the TCP user timeout value, in a Protocol-specific Property called tcp.userTimeoutValue " and this seems just right. Closing.

@mwelzl mwelzl closed this as completed Oct 27, 2023
@abrunstrom
Copy link
Contributor

Sorry, but I do not think this is right. It is not a tcp Connection. It is a (TAPS) Connection that uses TCP.

@abrunstrom abrunstrom reopened this Oct 27, 2023
@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 27, 2023

No need to be sorry of course! it was a good catch and I agree. Will fix.

mwelzl added a commit that referenced this issue Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants