Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why didn't we overload WithIPAddress for multicast? #1343

Closed
mwelzl opened this issue Sep 15, 2023 · 2 comments · Fixed by #1436
Closed

Why didn't we overload WithIPAddress for multicast? #1343

mwelzl opened this issue Sep 15, 2023 · 2 comments · Fixed by #1436
Assignees
Labels

Comments

@mwelzl
Copy link
Contributor

mwelzl commented Sep 15, 2023

From the review by Lars Eggert, COMMENT part:

Section 6.1.1, paragraph 4

    RemoteSpecifier.WithMulticastGroupIP(GroupAddress)

It's a design choice to not overload WithIPAddress here and instead
define WithMulticastGroupIP. I'd have overloaded, in order to avoid
the need for error handling if the wring type of IP address is passed
in.

@mwelzl mwelzl added the API label Sep 15, 2023
@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 17, 2023

There's a need for this when using SSN.

@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 17, 2023

... that need should be explained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants