You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a design choice to not overload WithIPAddress here and instead
define WithMulticastGroupIP. I'd have overloaded, in order to avoid
the need for error handling if the wring type of IP address is passed
in.
The text was updated successfully, but these errors were encountered:
From the review by Lars Eggert, COMMENT part:
Section 6.1.1, paragraph 4
It's a design choice to not overload
WithIPAddress
here and insteaddefine
WithMulticastGroupIP
. I'd have overloaded, in order to avoidthe need for error handling if the wring type of IP address is passed
in.
The text was updated successfully, but these errors were encountered: