Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS = TCP/TLS ? #1344

Closed
mwelzl opened this issue Sep 15, 2023 · 1 comment · Fixed by #1416
Closed

HTTPS = TCP/TLS ? #1344

mwelzl opened this issue Sep 15, 2023 · 1 comment · Fixed by #1416
Labels

Comments

@mwelzl
Copy link
Contributor

mwelzl commented Sep 15, 2023

From the review by Lars Eggert, COMMENT part:

Section 6.1.4, paragraph 3

    RemoteSpecifier := NewRemoteEndpoint()
    RemoteSpecifier.WithHostname("[example.com](http://example.com/)")
    RemoteSpecifier.WithService("https")

Does WithService("https") implicitly set WithProtocol(TCP/TLS) or
is that missing from the example? If it does, which other such
implications are defined?

@mwelzl mwelzl added the API label Sep 15, 2023
@mwelzl mwelzl changed the title HTTPS = TCL/TLS ? HTTPS = TCP/TLS ? Oct 11, 2023
@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 11, 2023

In the absence of "WithProtocol", it's not clear what exactly the stack is, and it shouldn't be. The Transport Services system should choose the right protocol stack for the requested service. Does this need text? Perhaps, just to say this, close to the example...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant