Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname vs FQDN #1360

Closed
mwelzl opened this issue Sep 18, 2023 · 1 comment · Fixed by #1398
Closed

Hostname vs FQDN #1360

mwelzl opened this issue Sep 18, 2023 · 1 comment · Fixed by #1398

Comments

@mwelzl
Copy link
Contributor

mwelzl commented Sep 18, 2023

From the review by Paul Wouters, DISCUSS part:

Can WithHostname be unqualified? (God I hope not!)
If not, can the call WithHostname be renamed to WithFQDN ?
If it can be unqualified, how does one deal with credentials
and identifiers, eg with a 'search domain' containing multiple
domains, RemoteSpecifier.WithHostname("mail") could end up on
either mail.example.com or mail.example.net (or heaven forbid,
the .mail TLD)

@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 2, 2023

Should be a comment in the implementation draft (hostname is expected to be a FQDN).
In API: applications SHOULD pass FQDNs.

tfpauly added a commit that referenced this issue Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants