Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Framer to Figure 3 #417

Closed
mirjak opened this issue Jan 15, 2020 · 2 comments
Closed

Add Framer to Figure 3 #417

mirjak opened this issue Jan 15, 2020 · 2 comments

Comments

@mirjak
Copy link
Contributor

mirjak commented Jan 15, 2020

Reading something about framers in section 4.1.4 came actually a bit as a surprise to me as we don't talk a lot about framer earlier in the document (yes there is one forward reference in section 2.2 but that's it). Now that we have message in Figure 4, we should maybe also add framers...?

@mirjak
Copy link
Contributor Author

mirjak commented Jan 15, 2020

Also maybe we should say a bit more what framers are than we currently do?

The current text is:
" * Framer: A Framer is a data translation layer that can be added to
a Connection to define how application-layer Messages are
transmitted over a transport protocol. This is particularly
relevant for protocols that otherwise present unstructured
streams, such as TCP."

We could probably add to this:
"A framer can define a bit pattern or syntax such as a length field or prelimiter that is pre- or suspended by the transport service to the message's bytes and is know by the transport service or application on the other endpoint to parse the received bytes into a message."

@tfpauly tfpauly changed the title Add Framer to Figure 4? Add Framer to Figure 3 Jan 24, 2020
@tfpauly
Copy link
Contributor

tfpauly commented Jan 24, 2020

Framer goes at bottom of API above implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants