Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event for PMTU changes #630

Closed
martinduke opened this issue Aug 7, 2020 · 7 comments
Closed

Event for PMTU changes #630

martinduke opened this issue Aug 7, 2020 · 7 comments

Comments

@martinduke
Copy link
Contributor

sec 7.1.9.
We're going to need an event for MTU changes. These can't simply be Send errors because the Sent event might go first, or the transport might be sending a probe with padding that doesn't correspond to a message.

@gorryfair
Copy link
Contributor

So does this mean MTU of the interface or PMTU of the path?

  • It seems simple to add an event for interface MTU changes.
  • For the PMTU, this raises a few questions before we add:
    (i) I can see the motivation for an event for a decrease in PMTU, and that seems relatively easy to add ... and could also return the new upper limit
    (ii) Would the same also be true of an increase in the PMTU? If so, it could be helpful if the upper layer probably says how "large" it is interested in using - e.g., DPLPMTUD has the notion of MAX_PLPMTU as an upper bound on probing.

@martinduke
Copy link
Contributor Author

PMTU of the path. I don't have a strong opinion on increases, but I would probably have an event for increases and not bother with the maximum. An unnecessary increase notification seems less expensive than another bit of API to specify the max.

@tfpauly
Copy link
Contributor

tfpauly commented Aug 14, 2020

Just add a path changed event to the application (similar to the one in implementation).

@tfpauly tfpauly self-assigned this Aug 14, 2020
@tfpauly
Copy link
Contributor

tfpauly commented Aug 14, 2020

Add event to Section 7.3?

@gorryfair
Copy link
Contributor

Just to be sure: This is a Path Changed Event, not a specific event relating to PMTU size.

mirjak added a commit that referenced this issue Sep 2, 2020
addresses #630 

However, we now have this path change event but it seems we actually don't have an interface to the access the path object to figure out what exactly changed...?
@gorryfair
Copy link
Contributor

New text looked good, I think this issue has been resolved.

@mwelzl mwelzl closed this as completed Oct 2, 2020
@mwelzl
Copy link
Contributor

mwelzl commented Oct 2, 2020

#648 closed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants