Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To abstract or not to abstract? That is the question #658

Closed
squarooticus opened this issue Sep 10, 2020 · 5 comments
Closed

To abstract or not to abstract? That is the question #658

squarooticus opened this issue Sep 10, 2020 · 5 comments
Assignees
Labels

Comments

@squarooticus
Copy link
Collaborator

Selection property querying is better than it was, but querying still feels odd:

  • Using "has been applied" to mean "on" or "in use" or "active" necessitates a bunch of explanatory text in §5.2 that would otherwise be unnecessary.

  • Reporting "true" for properties that are "on" or "in use" or "active" is very UNIX-y, but less abstract than I'd like to see here. At least we're not encoding -1 as a special return value anymore. A perhaps suitably abstract interface here would be something like:

tp := Connection.GetTransportProperties()
if tp.has('reliability'): ...
@mwelzl
Copy link
Contributor

mwelzl commented Sep 11, 2020

Welcome, author!

@squarooticus
Copy link
Collaborator Author

Ugh. Can I insert a GIF of a pile of books falling on me?

@squarooticus squarooticus self-assigned this Sep 29, 2020
squarooticus added a commit to squarooticus/api-drafts that referenced this issue Oct 20, 2020
@tfpauly
Copy link
Contributor

tfpauly commented Oct 23, 2020

Also, make SecurityParameters more abstract (don't do "strings" that look like Python).

squarooticus added a commit to squarooticus/api-drafts that referenced this issue Jan 28, 2021
squarooticus added a commit to squarooticus/api-drafts that referenced this issue Jan 28, 2021
@squarooticus
Copy link
Collaborator Author

Also, make SecurityParameters more abstract (don't do "strings" that look like Python).

I made a change in the third commit of #658. LMK if that matches your expectations.

@squarooticus
Copy link
Collaborator Author

Er, I mean #687. @tfpauly

squarooticus added a commit to squarooticus/api-drafts that referenced this issue Feb 17, 2021
squarooticus added a commit to squarooticus/api-drafts that referenced this issue Feb 17, 2021
squarooticus added a commit to squarooticus/api-drafts that referenced this issue Feb 17, 2021
squarooticus added a commit to squarooticus/api-drafts that referenced this issue Feb 17, 2021
@britram britram closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants