Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutability of Preconnection objects is unclear (Sec 2) #744

Closed
britram opened this issue Apr 6, 2021 · 2 comments · Fixed by #1004
Closed

mutability of Preconnection objects is unclear (Sec 2) #744

britram opened this issue Apr 6, 2021 · 2 comments · Fixed by #1004

Comments

@britram
Copy link
Contributor

britram commented Apr 6, 2021

Preconnections are mutable, until they are not. The second paragraph of section 2 states "bundles of properties an application can both read and write", which seems to conflict with this. Para should lead with the fact of mutable mutability over the preconnection lifecycle, not "is mutable".

@tfpauly
Copy link
Contributor

tfpauly commented Apr 9, 2021

The Connection/Listener makes a deep copy that is now immutable, but the original object is still mutable.

@tfpauly
Copy link
Contributor

tfpauly commented Apr 9, 2021

the implementation should ensure that the copy of the properties held by the Connection or Listener is immutable.

the implementation should ensure that the copy of the properties held by the Connection or Listener is not modified by changes the application makes to the original Preconnection object.

@tfpauly tfpauly self-assigned this Apr 9, 2021
tfpauly added a commit that referenced this issue Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants