Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that we use events to model asynchonous operations #1011

Merged
merged 2 commits into from Mar 23, 2022
Merged

Make it clear that we use events to model asynchonous operations #1011

merged 2 commits into from Mar 23, 2022

Conversation

britram
Copy link
Contributor

@britram britram commented Mar 23, 2022

fix #1009 in architecture.

@britram britram requested a review from mwelzl March 23, 2022 14:44
mwelzl
mwelzl approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@britram britram merged commit a39b0cc into master Mar 23, 2022
@britram britram deleted the 1009-event-means-async branch March 23, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwelzl mwelzl mwelzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider being less opinionated about event-based API earlier
2 participants
@britram @mwelzl