Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Transport Services System, architecture, and Transport Services Implementation #1288

Merged
merged 33 commits into from Oct 10, 2023

Conversation

gorryfair
Copy link
Contributor

@gorryfair gorryfair commented Sep 8, 2023

This document has been edited many ways, and this PR proposes a change in title and refinement in the use of the word 'architecture' to focus on the system specification, rather than the architectural principles. It does not intend to change the system in any way, this is intended as a language revision, to make it slightly less philosophical.
This is part 1 of addressing Eric's DISCUSS - the other part could be a title change, but this PR needs to land first because it will conflict with other development of text

This document has been edited many ways, and this PR proposes a change in title and refinement in the use of the word 'architecture' to focus on the system specification, rather than the architectural principles. It does not intend to change the system in any way, this is intended as a language revision, to make it slightly less philosophical.
@gorryfair gorryfair self-assigned this Sep 8, 2023
@gorryfair gorryfair linked an issue Sep 8, 2023 that may be closed by this pull request
@gorryfair
Copy link
Contributor Author

Happy also to muse with this change /Transport Services system/Transport Services System/ is people wish this...

Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many small suggestions... the most prevalent one being capitalization of the "System". I do this because you added it to the glossary, with capitals... and it makes sense to be added there, but then it really must be capitalized everywhere, I believe.

draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
gorryfair and others added 13 commits September 8, 2023 12:39
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
This capitalises "Transport Services System".
Removes most confusion between system and implementation.
Removes two definitions of these, the second one simply becoming text rather than definition.
Hopefully now in a fit state for reading!
@mwelzl
Copy link
Contributor

mwelzl commented Sep 8, 2023

Please also add the "Transport Services Implementation" to the glossary.

Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny ones. Ok for me to merge if you agree with these.

draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
gorryfair and others added 3 commits September 8, 2023 14:00
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
Co-authored-by: mwelzl <michawe@ifi.uio.no>
@gorryfair gorryfair changed the title A Transport Services System A Transport Services System, architecture, and Transport Services Implementation Sep 8, 2023
Some phrases are about the architecture of the system, but others are about the system itself, and some others about the implementation below the API. These are separate concepts, and this revision seeks to ensure we use them consistently where possible
Copy link
Contributor

@theri theri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(As an individual)
Just read over the changes and tripped over a few typos.

draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
gorryfair and others added 2 commits October 2, 2023 16:07
Co-authored-by: Reese Enghardt <ietf@tenghardt.net>
Co-authored-by: Reese Enghardt <ietf@tenghardt.net>
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
gorryfair and others added 2 commits October 2, 2023 16:32
Co-authored-by: Tommy Pauly <tpauly@apple.com>
Co-authored-by: Colin Perkins <csp@csperkins.org>
@gorryfair gorryfair requested a review from tfpauly October 2, 2023 17:05
Copy link
Contributor

@tfpauly tfpauly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo nits

draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
draft-ietf-taps-arch.md Outdated Show resolved Hide resolved
@tfpauly tfpauly merged commit 11b6c69 into master Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's in a name? That which we call a rose by any other name would smell just as sweet... BCP14 language
5 participants