Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain stacked layers of keep alive protocols #1452

Merged
merged 2 commits into from Nov 9, 2023
Merged

Conversation

tfpauly
Copy link
Contributor

@tfpauly tfpauly commented Nov 9, 2023

Closes #1428

Copy link
Contributor

@gorryfair gorryfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this follows what we talked about. I also think it is a very valuable example of how the stack deals with a property that might inform multiple layers - saying that a specific property does not infer that the implementation makes the same request at each layer. Thanks for doing this.

Copy link
Contributor

@abrunstrom abrunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good! made a small comment.

draft-ietf-taps-impl.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, in my opinion, and appears to say exactly what needs to be said. It makes me wonder in retrospect why I couldn't wrap my head this.

@tfpauly tfpauly merged commit 990cbc9 into master Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What are implications of keepAlive and keepaliveTimeout on stacked protocols with keepalives?
4 participants