Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Listener object to the API #332

Merged
merged 1 commit into from Jun 14, 2019
Merged

Added Listener object to the API #332

merged 1 commit into from Jun 14, 2019

Conversation

philsbln
Copy link
Contributor

This adds an explicit Listener object to the API (closes #301) to

@philsbln philsbln added the API label Jun 12, 2019
@philsbln philsbln added this to the before ietf-105 Montreal milestone Jun 12, 2019
@philsbln philsbln requested review from tfpauly and mwelzl June 12, 2019 14:27
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks just right to me, thanks a lot for doing this!
In particular having read #269 again, I believe that @tfpauly should definitely have the last word on this one. So I'll go with whatever @tfpauly says.

@mwelzl mwelzl merged commit 74649d8 into master Jun 14, 2019
@philsbln philsbln deleted the philsbln/listener-obj branch June 17, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants