Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address privacy property, #300 #372

Merged
merged 2 commits into from Nov 21, 2019
Merged

Address privacy property, #300 #372

merged 2 commits into from Nov 21, 2019

Conversation

tfpauly
Copy link
Contributor

@tfpauly tfpauly commented Nov 20, 2019

Address #300

mwelzl
mwelzl requested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just nits

draft-ietf-taps-interface.md Outdated Show resolved Hide resolved
draft-ietf-taps-interface.md Outdated Show resolved Hide resolved
abrunstrom
abrunstrom approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@abrunstrom abrunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

philsbln
philsbln approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@philsbln philsbln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was really missing this one .

@britram britram merged commit 21b590d into master Nov 21, 2019
@britram britram deleted the tfp/temporary-address branch November 24, 2019 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwelzl mwelzl mwelzl approved these changes

@philsbln philsbln philsbln approved these changes

@abrunstrom abrunstrom abrunstrom approved these changes

@britram britram Awaiting requested review from britram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tfpauly @mwelzl @philsbln @abrunstrom @britram