Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add one more pointer to Framers #442

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Add one more pointer to Framers #442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c23cee
Add one more pointer to Framers
mirjak Jan 16, 2020
65788d7
Update draft-ietf-taps-interface.md
mirjak Jan 17, 2020
98180a6
Update draft-ietf-taps-interface.md
mirjak Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions draft-ietf-taps-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,6 +1378,10 @@ It can be used to identify send events (see {{send-events}}) related to a specif
The optional endOfMessage parameter supports partial sending and is described in
{{send-partial}}.

Framers can be used to extend or modify the message data
with additional information that can be processed at the receiver to detect message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with additional information that can be processed at the receiver to detect message
with additional information that can be processed at the receiver and to determine message

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this reads strangely - as if processing at the receiver is one thing, and determining message boundaries is another. First, what's your motivation to change it - what else would you want to do with framers at the receiver? This text could be changed to say ", e.g., to determine message boundaries at the receiver" - which would read better, but immediately raise the question: "what else?". So we'd need another example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Michael that the proposed changed reads a bit awkward. I'd prefer to just not change it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation was to clarify that framers can be used for other things than "just" determining message boundaries, e.g., extracting information and making them available through the message context. – it is a nit here anyway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I suggest to keep the old text. We elaborate on what framers can do in the {{framing}} section that this points too anyway.

boundaries. This is further decribed in {{framing}}.

## Basic Sending {#send-basic}

The most basic form of sending on a connection involves enqueuing a single Data
Expand Down